[
https://issues.apache.org/jira/browse/GEODE-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317086#comment-16317086
]
ASF GitHub Bot commented on GEODE-4246:
---------------------------------------
PivotalSarge opened a new pull request #1252: GEODE-4246: Skip setting the
mcast-port property.
URL: https://github.com/apache/geode/pull/1252
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [n/a] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
@upthewaterspout @bschuchardt @WireBaron @galen-pivotal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove mcast-port from build generated gemfire.properties
> ---------------------------------------------------------
>
> Key: GEODE-4246
> URL: https://issues.apache.org/jira/browse/GEODE-4246
> Project: Geode
> Issue Type: Bug
> Components: tests
> Reporter: Michael Dodge
> Assignee: Michael Dodge
>
> Originally from [~upthewaterspout]:
> Nick and I discovered that the gradle build is generating a
> {{gemfire.properties}} in the {{integrationTest}} directory (and maybe
> others). This {{gemfire.properties}} contains an {{mcast-port}}.
> Unfortunately, this means that all of our tests run with different properties
> when run through gradle as when run through the IDE.
> The default mcast port is 0, which seems like a way better default than
> having all tests run with mcast enabled. We should remove this property from
> the build generated gemfire.properties and fix whatever tests fail.
> See {{gradlet/test.gradle}} and {{TestPropertiesWriter.groovy}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
