[
https://issues.apache.org/jira/browse/GEODE-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323161#comment-16323161
]
ASF GitHub Bot commented on GEODE-4246:
---------------------------------------
upthewaterspout closed pull request #1252: GEODE-4246: Skip setting the
mcast-port property.
URL: https://github.com/apache/geode/pull/1252
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/buildSrc/src/main/groovy/org/apache/geode/gradle/TestPropertiesWriter.groovy
b/buildSrc/src/main/groovy/org/apache/geode/gradle/TestPropertiesWriter.groovy
index 0f43d3c3ed..58e61f75c0 100644
---
a/buildSrc/src/main/groovy/org/apache/geode/gradle/TestPropertiesWriter.groovy
+++
b/buildSrc/src/main/groovy/org/apache/geode/gradle/TestPropertiesWriter.groovy
@@ -23,7 +23,6 @@ import org.apache.mina.util.AvailablePortFinder;
public class TestPropertiesWriter {
public static void writeTestProperties(File parent, String name) {
Properties props = new Properties();
- props.setProperty('mcast-port',
Integer.toString(AvailablePortFinder.getNextAvailable()));
props.setProperty('log-level', 'config');
File propsFile = new File(testResultsDir(parent, name),
'gemfire.properties');
BufferedWriter writer = propsFile.newWriter();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove mcast-port from build generated gemfire.properties
> ---------------------------------------------------------
>
> Key: GEODE-4246
> URL: https://issues.apache.org/jira/browse/GEODE-4246
> Project: Geode
> Issue Type: Bug
> Components: tests
> Reporter: Michael Dodge
> Assignee: Michael Dodge
>
> Originally from [~upthewaterspout]:
> Nick and I discovered that the gradle build is generating a
> {{gemfire.properties}} in the {{integrationTest}} directory (and maybe
> others). This {{gemfire.properties}} contains an {{mcast-port}}.
> Unfortunately, this means that all of our tests run with different properties
> when run through gradle as when run through the IDE.
> The default mcast port is 0, which seems like a way better default than
> having all tests run with mcast enabled. We should remove this property from
> the build generated gemfire.properties and fix whatever tests fail.
> See {{gradlet/test.gradle}} and {{TestPropertiesWriter.groovy}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
