[
https://issues.apache.org/jira/browse/GEODE-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317293#comment-16317293
]
ASF GitHub Bot commented on GEODE-4255:
---------------------------------------
PivotalSarge opened a new pull request #1254: GEODE-4255: Remove mandatory
failure on macOS.
URL: https://github.com/apache/geode/pull/1254
Since GatewayReceiverImpl uses a much less brittle string comparison now,
the case that this mandatory failure was trying to avoid no longer exists.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
@jhuynh1 @nabarunnag
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove mandatory failure on macOS for
> WANConfigurationJUnitTest.test_ValidateGatewayReceiverAttributes_WrongBindAddress
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-4255
> URL: https://issues.apache.org/jira/browse/GEODE-4255
> Project: Geode
> Issue Type: Bug
> Components: wan
> Reporter: Michael Dodge
> Assignee: Michael Dodge
>
> The JUnit test
> {{WANConfigurationJUnitTest.test_ValidateGatewayReceiverAttributes_WrongBindAddress}}
> always fails on macOS because there is code in lines 428-430 of
> {{WANConfigurationJUnitTest.java}} that calls {{fail()}} if the OS name is
> {{Mac OS X}}. The preceding comment says that the mandatory failure is in
> response to a change in messaging in the Yosemite release of macOS that
> results in a failure in "GatewayReceiverImpl around line 167".
> At a minimum, it seems like this test should just immediately return
> successfully rather than always fail. (If the thinking was that always
> failing would induce someone to fix the underlying problem, that obviously
> hasn't worked very well so far.) Alternatively, it would be nice to verify
> that the problem still exists. Ideally, the underlying problem ought to be
> fixed.
> {noformat}
> org.apache.geode.internal.cache.wan.misc.WANConfigurationJUnitTest >
> test_ValidateGatewayReceiverAttributes_WrongBindAddress FAILED
> java.lang.AssertionError: Failing to avoid known hang on Mac OS X.
> at org.junit.Assert.fail(Assert.java:88)
> at
> org.apache.geode.internal.cache.wan.misc.WANConfigurationJUnitTest.test_ValidateGatewayReceiverAttributes_WrongBindAddress(WANConfigurationJUnitTest.java:429)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
