[
https://issues.apache.org/jira/browse/GEODE-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322736#comment-16322736
]
ASF GitHub Bot commented on GEODE-4255:
---------------------------------------
upthewaterspout closed pull request #1254: GEODE-4255: Remove mandatory failure
on macOS.
URL: https://github.com/apache/geode/pull/1254
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WANConfigurationJUnitTest.java
b/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WANConfigurationJUnitTest.java
index 7065b6534c..8e7be1e4b8 100644
---
a/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WANConfigurationJUnitTest.java
+++
b/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WANConfigurationJUnitTest.java
@@ -418,16 +418,12 @@ public void test_ValidateGatewayReceiverAttributes_2() {
}
/**
- * This test takes a minimum of 120s to execute. It is known to hang on Mac
OS X Yosemite do to
- * changes in the the message string checked in GatewayReceiverImpl around
line 167. Expects
- * "Cannot assign requested address" but gets "Can't assign requested
address". Timeout after 150s
- * to safeguard against hanging on other platforms that may differ.
+ * This test takes a minimum of 120s to execute. Based on the experiences of
the Yosemite release
+ * of macOS, timeout after 150s to safeguard against hanging on other
platforms that may have
+ * different error messages.
*/
@Test(timeout = 150000)
public void test_ValidateGatewayReceiverAttributes_WrongBindAddress() {
- if (System.getProperty("os.name").equals("Mac OS X")) {
- fail("Failing to avoid known hang on Mac OS X.");
- }
cache = new CacheFactory().set(MCAST_PORT, "0").create();
GatewayReceiverFactory fact = cache.createGatewayReceiverFactory();
fact.setStartPort(50504);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove mandatory failure on macOS for
> WANConfigurationJUnitTest.test_ValidateGatewayReceiverAttributes_WrongBindAddress
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-4255
> URL: https://issues.apache.org/jira/browse/GEODE-4255
> Project: Geode
> Issue Type: Bug
> Components: wan
> Reporter: Michael Dodge
> Assignee: Michael Dodge
>
> The JUnit test
> {{WANConfigurationJUnitTest.test_ValidateGatewayReceiverAttributes_WrongBindAddress}}
> always fails on macOS because there is code in lines 428-430 of
> {{WANConfigurationJUnitTest.java}} that calls {{fail()}} if the OS name is
> {{Mac OS X}}. The preceding comment says that the mandatory failure is in
> response to a change in messaging in the Yosemite release of macOS that
> results in a failure in "GatewayReceiverImpl around line 167".
> At a minimum, it seems like this test should just immediately return
> successfully rather than always fail. (If the thinking was that always
> failing would induce someone to fix the underlying problem, that obviously
> hasn't worked very well so far.) Alternatively, it would be nice to verify
> that the problem still exists. Ideally, the underlying problem ought to be
> fixed.
> {noformat}
> org.apache.geode.internal.cache.wan.misc.WANConfigurationJUnitTest >
> test_ValidateGatewayReceiverAttributes_WrongBindAddress FAILED
> java.lang.AssertionError: Failing to avoid known hang on Mac OS X.
> at org.junit.Assert.fail(Assert.java:88)
> at
> org.apache.geode.internal.cache.wan.misc.WANConfigurationJUnitTest.test_ValidateGatewayReceiverAttributes_WrongBindAddress(WANConfigurationJUnitTest.java:429)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
