[
https://issues.apache.org/jira/browse/GEODE-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321359#comment-16321359
]
ASF GitHub Bot commented on GEODE-4236:
---------------------------------------
pdxrunner opened a new pull request #1268: GEODE-4236: Increase default timeout
for await methods
URL: https://github.com/apache/geode/pull/1268
to avoid false failures on slow machines
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ConfigureEvictionThroughGfsh AcceptanceTest fails due to timeout --
> Reconsider default timeout for GfshRule
> -----------------------------------------------------------------------------------------------------------
>
> Key: GEODE-4236
> URL: https://issues.apache.org/jira/browse/GEODE-4236
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Patrick Rhomberg
>
> {noformat}
> org.apache.geode.management.internal.cli.commands.ConfigureEvictionThroughGfsh
> > configureEvictionByEntryCount FAILED
> org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshScript.awaitLoudly(GfshScript.java:141)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshScript.awaitIfNecessary(GfshScript.java:112)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:98)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshScript.execute(GfshScript.java:105)
> at
> org.apache.geode.management.internal.cli.commands.ConfigureEvictionThroughGfsh.configureEvictionByEntryCount(ConfigureEvictionThroughGfsh.java:50)
> {noformat}
> Examining the test itself, it seems that the call
> {noformat}
> GfshExecution execution = GfshScript
> .of("start locator --name=locator", "start server --name=server",
> "create region --name=region1 --eviction-action=local-destroy
> --eviction-entry-count=1000 --type=REPLICATE",
> "create region --name=region2 --eviction-action=overflow-to-disk
> --eviction-entry-count=1000 --type=REPLICATE",
> "create region --name=region3 --eviction-action=overflow-to-disk
> --eviction-entry-count=1000 --type=REPLICATE_PERSISTENT",
> "create region --name=region4 --eviction-action=local-destroy
> --eviction-entry-count=1000 --type=LOCAL",
> "create region --name=region5 --eviction-action=overflow-to-disk
> --eviction-entry-count=1000 --type=LOCAL")
> .execute(gfsh);
> {noformat}
> is executing under the default GfshExecution timeout of 2 minutes. 2 might
> be optimistic for the creation of two members and five regions, depending on
> computational resources available.
> The use of the 2 minute timeout may be the result of an unclear testing API,
> or might consider prepending a message with the execution's timeout to the
> gfsh output stream.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
