[
https://issues.apache.org/jira/browse/GEODE-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322419#comment-16322419
]
ASF GitHub Bot commented on GEODE-4236:
---------------------------------------
pdxrunner closed pull request #1268: GEODE-4236: Increase default timeout for
await methods
URL: https://github.com/apache/geode/pull/1268
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshScript.java
b/geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshScript.java
index 03a27468d2..69f3a9ea5c 100644
---
a/geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshScript.java
+++
b/geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshScript.java
@@ -25,7 +25,7 @@
private final String[] commands;
private String name;
private TimeUnit timeoutTimeUnit = TimeUnit.MINUTES;
- private int timeout = 2;
+ private int timeout = 4;
private boolean awaitQuietly = false;
private int expectedExitValue = 0;
private List<String> extendedClasspath = new ArrayList<>();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ConfigureEvictionThroughGfsh AcceptanceTest fails due to timeout --
> Reconsider default timeout for GfshRule
> -----------------------------------------------------------------------------------------------------------
>
> Key: GEODE-4236
> URL: https://issues.apache.org/jira/browse/GEODE-4236
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Patrick Rhomberg
>
> {noformat}
> org.apache.geode.management.internal.cli.commands.ConfigureEvictionThroughGfsh
> > configureEvictionByEntryCount FAILED
> org.junit.ComparisonFailure: expected:<[tru]e> but was:<[fals]e>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshScript.awaitLoudly(GfshScript.java:141)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshScript.awaitIfNecessary(GfshScript.java:112)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshRule.execute(GfshRule.java:98)
> at
> org.apache.geode.test.junit.rules.gfsh.GfshScript.execute(GfshScript.java:105)
> at
> org.apache.geode.management.internal.cli.commands.ConfigureEvictionThroughGfsh.configureEvictionByEntryCount(ConfigureEvictionThroughGfsh.java:50)
> {noformat}
> Examining the test itself, it seems that the call
> {noformat}
> GfshExecution execution = GfshScript
> .of("start locator --name=locator", "start server --name=server",
> "create region --name=region1 --eviction-action=local-destroy
> --eviction-entry-count=1000 --type=REPLICATE",
> "create region --name=region2 --eviction-action=overflow-to-disk
> --eviction-entry-count=1000 --type=REPLICATE",
> "create region --name=region3 --eviction-action=overflow-to-disk
> --eviction-entry-count=1000 --type=REPLICATE_PERSISTENT",
> "create region --name=region4 --eviction-action=local-destroy
> --eviction-entry-count=1000 --type=LOCAL",
> "create region --name=region5 --eviction-action=overflow-to-disk
> --eviction-entry-count=1000 --type=LOCAL")
> .execute(gfsh);
> {noformat}
> is executing under the default GfshExecution timeout of 2 minutes. 2 might
> be optimistic for the creation of two members and five regions, depending on
> computational resources available.
> The use of the 2 minute timeout may be the result of an unclear testing API,
> or might consider prepending a message with the execution's timeout to the
> gfsh output stream.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
