[
https://issues.apache.org/jira/browse/GEODE-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329168#comment-16329168
]
ASF GitHub Bot commented on GEODE-4299:
---------------------------------------
nreich commented on a change in pull request #1290: GEODE-4299: refactor
eviction
URL: https://github.com/apache/geode/pull/1290#discussion_r161903880
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractLRURegionMap.java
##########
@@ -14,816 +14,15 @@
*/
package org.apache.geode.internal.cache;
Review comment:
Maybe we should just go ahead and remove the class now: if we remove it
later, we will have the same issue of possible merge conflicts caused by the
change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> some internal classes for eviction are serializable for no apparent reason
> --------------------------------------------------------------------------
>
> Key: GEODE-4299
> URL: https://issues.apache.org/jira/browse/GEODE-4299
> Project: Geode
> Issue Type: Bug
> Components: eviction
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
> Labels: pull-request-available
>
> The eviction controller classes are serializable even though they can no
> longer be safely serialized.
> Also, in general, the internal classes for eviction are confusing. The
> dependencies between them are not clear and multiple classes attempt to do
> the same thing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
