[
https://issues.apache.org/jira/browse/GEODE-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329630#comment-16329630
]
ASF GitHub Bot commented on GEODE-4299:
---------------------------------------
dschneider-pivotal commented on a change in pull request #1290: GEODE-4299:
refactor eviction
URL: https://github.com/apache/geode/pull/1290#discussion_r162200874
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/EvictableRegion.java
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import org.apache.geode.StatisticsFactory;
+import org.apache.geode.cache.EvictionAttributes;
+import org.apache.geode.internal.cache.eviction.EvictionController;
+
+public interface EvictableRegion {
+ EvictionAttributes getEvictionAttributes();
+
+ boolean getOffHeap();
Review comment:
this was a preexisting method on the implementation classes that I just
added to this new interface. So for this PR I don't plan on renaming it. I
think it comes from the external RegionAttributes interface so renaming it
could break existing user's code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> some internal classes for eviction are serializable for no apparent reason
> --------------------------------------------------------------------------
>
> Key: GEODE-4299
> URL: https://issues.apache.org/jira/browse/GEODE-4299
> Project: Geode
> Issue Type: Bug
> Components: eviction
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
> Labels: pull-request-available
>
> The eviction controller classes are serializable even though they can no
> longer be safely serialized.
> Also, in general, the internal classes for eviction are confusing. The
> dependencies between them are not clear and multiple classes attempt to do
> the same thing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
