[
https://issues.apache.org/jira/browse/GEODE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337868#comment-16337868
]
ASF subversion and git services commented on GEODE-3570:
--------------------------------------------------------
Commit 3506808f892e5f84c49f83c507d1b14477491602 in geode-native's branch
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=3506808 ]
GEODE-3570: Standardizes time values. (#191)
* GEODE-3570: Standardizes time values.
- Durations that can be disabled use std::chrono::duration::zero().
- Fixes durations that are out of range based on documention.
- Fixes comparison of durations against limits or disabled.
- Updates documentation for changes to duration values.
- Fixes exception throw for invalid arguments.
- Updates .NET API documents.
> Standardize on model for infinity that doesn't use int overloading
> ------------------------------------------------------------------
>
> Key: GEODE-3570
> URL: https://issues.apache.org/jira/browse/GEODE-3570
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Mark Hanson
> Assignee: Jacob S. Barrett
> Priority: Major
> Labels: pull-request-available
>
> See discussion here http://markmail.org/thread/hwrkg5cra57lyvo3
> Currently the code in the native client follows various conventions. We would
> like to standardize the code to use a model where instead of overloading int
> to mean infinity on a wait, to create two separate function calls. One for
> wait indefinitely wait() and one to wait for a duration
> waitDuration(duration)
> ThinClientRegion.cpp:2996 executeFunction needs refactoring.
> PoolAttributes.hpp:69 setRetryAttempts needs to be retitled attempts and then
> the using functions need to use it appropriately.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
