[
https://issues.apache.org/jira/browse/GEODE-6797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan McMahon updated GEODE-6797:
--------------------------------
Description:
It was found that the AppServer module in Geode 1.9.0 release package is
missing a dependency, specifically `geode-modules-1.9.0`. This appears to be
due to the way we are zipping the module and specifying its dependencies in
Gradle.
>From Dan Smith:
{noformat}
The basic issue is that this task includes the module jar in the zip in weird
way, but doesn't declare the jar task as a dependency (in
geode-modules-assembly/build.gradle):
task distAppServer(type: Zip, dependsOn:
[':extensions:geode-modules-session:jar',
':extensions:geode-modules-session-internal:jar',
':extensions:geode-modules-tomcat7:jar',
':extensions:geode-modules-tomcat8:jar',
':extensions:geode-modules-tomcat9:jar']) {
baseName = moduleBaseName
classifier = "AppServer"
into('lib') {
from getJarArtifact(':extensions:geode-modules-session')
from getJarArtifact(':extensions:geode-modules-session-internal')
from getJarArtifact(':extensions:geode-modules')
from configurations.slf4jDeps
}
So I think it's somewhat indeterminant if any given build contains that jar in
the zip. If we run the distributedTest on that particular build, we would catch
the issue, but that's not how our build works (at least for geode releases).
{noformat}
was:
It was found that the AppServer module in Geode 1.9.0 release package is
missing a dependency, specifically `geode-modules-1.9.0`. This appears to be
due to the way we are zipping the module and specifying its dependencies in
Gradle.
>From Dan Smith:
{noformat}
The basic issue is that this task includes the module jar in the zip in weird
way, but doesn't declare the jar task as a dependency (in
geode-modules-assembly/build.gradle):
task distAppServer(type: Zip, dependsOn:
[':extensions:geode-modules-session:jar',
':extensions:geode-modules-session-internal:jar',
':extensions:geode-modules-tomcat7:jar',
':extensions:geode-modules-tomcat8:jar',
':extensions:geode-modules-tomcat9:jar']) {
baseName = moduleBaseName
classifier = "AppServer"
into('lib') {
from getJarArtifact(':extensions:geode-modules-session')
from getJarArtifact(':extensions:geode-modules-session-internal')
from getJarArtifact(':extensions:geode-modules')
from configurations.slf4jDeps
}
{noformat}
> Possibility for missing dependencies in session state modules
> -------------------------------------------------------------
>
> Key: GEODE-6797
> URL: https://issues.apache.org/jira/browse/GEODE-6797
> Project: Geode
> Issue Type: Bug
> Components: build
> Reporter: Ryan McMahon
> Priority: Major
> Labels: GeodeCommons
>
> It was found that the AppServer module in Geode 1.9.0 release package is
> missing a dependency, specifically `geode-modules-1.9.0`. This appears to be
> due to the way we are zipping the module and specifying its dependencies in
> Gradle.
> From Dan Smith:
>
> {noformat}
> The basic issue is that this task includes the module jar in the zip in weird
> way, but doesn't declare the jar task as a dependency (in
> geode-modules-assembly/build.gradle):
> task distAppServer(type: Zip, dependsOn:
> [':extensions:geode-modules-session:jar',
> ':extensions:geode-modules-session-internal:jar',
> ':extensions:geode-modules-tomcat7:jar',
> ':extensions:geode-modules-tomcat8:jar',
> ':extensions:geode-modules-tomcat9:jar']) {
> baseName = moduleBaseName
> classifier = "AppServer"
> into('lib') {
> from getJarArtifact(':extensions:geode-modules-session')
> from getJarArtifact(':extensions:geode-modules-session-internal')
> from getJarArtifact(':extensions:geode-modules')
> from configurations.slf4jDeps
> }
> So I think it's somewhat indeterminant if any given build contains that jar
> in the zip. If we run the distributedTest on that particular build, we would
> catch the issue, but that's not how our build works (at least for geode
> releases).
> {noformat}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
