[ 
https://issues.apache.org/jira/browse/GEODE-6797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846885#comment-16846885
 ] 

Jacob S. Barrett commented on GEODE-6797:
-----------------------------------------

So when built on a clean system and in parallel it would be possible for this 
zip task to complete before the dependent jar exists. [~rhoughton] or 
[~prhomberg] is there a better Gradle way to do this. I recall there was a way 
to define the {{from}} in a way that we guarantee completion of the output task 
such that you didn't need to externally set the {{dependsOn}}.

> Possibility for missing dependencies in session state modules
> -------------------------------------------------------------
>
>                 Key: GEODE-6797
>                 URL: https://issues.apache.org/jira/browse/GEODE-6797
>             Project: Geode
>          Issue Type: Bug
>          Components: build
>            Reporter: Ryan McMahon
>            Priority: Major
>              Labels: GeodeCommons
>
> It was found that the AppServer module in Geode 1.9.0 release package is 
> missing a dependency, specifically `geode-modules-1.9.0`.  This appears to be 
> due to the way we are zipping the module and specifying its dependencies in 
> Gradle.
> From Dan Smith:
>  
> {noformat}
> The basic issue is that this task includes the module jar in the zip in weird 
> way, but doesn't declare the jar task as a dependency (in 
> geode-modules-assembly/build.gradle):
> task distAppServer(type: Zip, dependsOn: 
> [':extensions:geode-modules-session:jar',
>  ':extensions:geode-modules-session-internal:jar',
>  ':extensions:geode-modules-tomcat7:jar',
>  ':extensions:geode-modules-tomcat8:jar',
>  ':extensions:geode-modules-tomcat9:jar']) {
>  baseName = moduleBaseName
>  classifier = "AppServer"
> into('lib') {
>  from getJarArtifact(':extensions:geode-modules-session')
>  from getJarArtifact(':extensions:geode-modules-session-internal')
>  from getJarArtifact(':extensions:geode-modules')
>  from configurations.slf4jDeps
>  }
> So I think it's somewhat indeterminant if any given build contains that jar 
> in the zip. If we run the distributedTest on that particular build, we would 
> catch the issue, but that's not how our build works (at least for geode 
> releases).
> {noformat}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to