[
https://issues.apache.org/jira/browse/GEODE-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958135#comment-16958135
]
ASF subversion and git services commented on GEODE-6807:
--------------------------------------------------------
Commit c083ad58b880d782a5f6b9e84936cdaa7d97504e in geode's branch
refs/heads/revert-4189-revert-4086-feature/GEODE-6807 from Mario Ivanac
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c083ad5 ]
Revert "Revert "GEODE-6807: cache adviseUpdate and adviseAllEventsOrCached"
(#4189)"
This reverts commit e225ffcd5dc8f15ae59b46dc24baefcc253801f2.
> changing advisors to cache advice can improve performance
> ---------------------------------------------------------
>
> Key: GEODE-6807
> URL: https://issues.apache.org/jira/browse/GEODE-6807
> Project: Geode
> Issue Type: Improvement
> Components: core
> Reporter: Darrel Schneider
> Assignee: Mario Ivanac
> Priority: Major
> Labels: performance
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> Cluster messaging uses advisors to know what member of the cluster should be
> sent a message.
> Currently, every time and advisor is asked for advice to iterates over its
> profiles building up the advice in a HashSet that is returned.
> I found on a partitioned region client/server put benchmark (32 client
> threads, 2 servers with redundancy 1) that if I changed the method
> adviseAllEventsOrCached to remember what it computed, that it caused the put
> throughput to increase by 8%. [Update I reran and did not see an improvement
> so the original 8% difference may have been caused by something else].
> Advisors know when a profile is added, removed, or modified. When that
> happens any advice it has cached can be dropped. Also, the requestors of
> advice need to expect the Set they get back to be unmodifiable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
