[
https://issues.apache.org/jira/browse/GEODE-7792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108432#comment-17108432
]
ASF GitHub Bot commented on GEODE-7792:
---------------------------------------
Bill commented on a change in pull request #5116:
URL: https://github.com/apache/geode/pull/5116#discussion_r425911891
##########
File path: geode-membership/build.gradle
##########
@@ -38,9 +38,7 @@ dependencies {
//Jgroups is a core component of our membership system.
implementation('org.jgroups:jgroups')
- testImplementation(project(':geode-junit')) {
- exclude module: 'geode-logging'
- }
+ testImplementation(project(':geode-junit'))
Review comment:
each of these excludes was superfluous. the excludes were necessary in
other modules, where the exclusions broke what would have been circular
inter-module dependencies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> configure logging for geode-membership integration tests
> --------------------------------------------------------
>
> Key: GEODE-7792
> URL: https://issues.apache.org/jira/browse/GEODE-7792
> Project: Geode
> Issue Type: Improvement
> Components: membership
> Reporter: Bruce J Schuchardt
> Assignee: Bruce J Schuchardt
> Priority: Major
> Fix For: 1.13.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Integration tests for geode-membership do not have a log4j configuration. The
> subproject cannot depend on geode-log4j because that pulls in geode-core with
> its Alert appender and other things.
> Add a log4j configuration for tests in geode-membership so we can get proper
> log output from tests to diagnose failures.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
