[
https://issues.apache.org/jira/browse/GEODE-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144690#comment-17144690
]
ASF GitHub Bot commented on GEODE-8295:
---------------------------------------
lgtm-com[bot] commented on pull request #5289:
URL: https://github.com/apache/geode/pull/5289#issuecomment-649265042
This pull request **introduces 1 alert** and **fixes 1** when merging
b1827f612ae61b908f7f4f4098c691fafd96f6f9 into
5732a1c1ef9c8ccb979770a963d5c4b1b7324f1a - [view on
LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-5e63332d9040bfffe2b4547c1c047fa30a9e5a4d)
**new alerts:**
* 1 for Potential input resource leak
**fixed alerts:**
* 1 for Potential input resource leak
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> refactor/cleanup GeodeRedisServer
> ---------------------------------
>
> Key: GEODE-8295
> URL: https://issues.apache.org/jira/browse/GEODE-8295
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
>
> Here are some things to do to cleanup GeodeRedisServer:
> # remove main thread from GeodeRedisServer
> # remove NamedThreadFactory in favor of geode's LoggingThreadFactory and
> LoggingExecutors
> # remove logLevel since it is configured by gemfire
> # pass an existing cache to the GeodeRedisServer constructor
> # do region creation and initialization in RegionProvider
> # extract passive expiration code
> # extract netty server code
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
