[
https://issues.apache.org/jira/browse/GEODE-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144948#comment-17144948
]
ASF GitHub Bot commented on GEODE-8295:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #5289:
URL: https://github.com/apache/geode/pull/5289#discussion_r445582180
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisService.java
##########
@@ -77,7 +78,7 @@ private void startRedisServer(InternalCache cache) {
String.format("Starting GeodeRedisServer on bind address %s on port
%s",
Review comment:
Since you're working on this, could you move the log message after the
start so that we log the actual port used in the event that it is started on an
ephemeral port. (Otherwise it just says `Starting... on port 0`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> refactor/cleanup GeodeRedisServer
> ---------------------------------
>
> Key: GEODE-8295
> URL: https://issues.apache.org/jira/browse/GEODE-8295
> Project: Geode
> Issue Type: Improvement
> Components: redis
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
>
> Here are some things to do to cleanup GeodeRedisServer:
> # remove main thread from GeodeRedisServer
> # remove NamedThreadFactory in favor of geode's LoggingThreadFactory and
> LoggingExecutors
> # remove logLevel since it is configured by gemfire
> # pass an existing cache to the GeodeRedisServer constructor
> # do region creation and initialization in RegionProvider
> # extract passive expiration code
> # extract netty server code
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
