[
https://issues.apache.org/jira/browse/GEODE-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175664#comment-17175664
]
ASF GitHub Bot commented on GEODE-8333:
---------------------------------------
dschneider-pivotal commented on a change in pull request #5420:
URL: https://github.com/apache/geode/pull/5420#discussion_r468692943
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -59,17 +60,21 @@
public class ExecutionHandlerContext extends ChannelInboundHandlerAdapter {
private static final Logger logger = LogService.getLogger();
+ private static final Command TERMINATE_COMMAND = new Command();
private final Client client;
private final Channel channel;
private final RegionProvider regionProvider;
private final PubSub pubsub;
- private final EventLoopGroup subscriberGroup;
private final ByteBufAllocator byteBufAllocator;
private final byte[] authPassword;
private final Supplier<Boolean> allowUnsupportedSupplier;
private final Runnable shutdownInvoker;
private final RedisStats redisStats;
+ private final ExecutorService backgroundExecutor;
+ private final int MAX_QUEUED_COMMANDS = 100;
+ private final LinkedBlockingQueue<Command> commandQueue =
Review comment:
Could that cause a deadlock if the queue is full but not moving because
the current command is a publish waiting for the latch and the latch is not
being cleared by subscribe because it is waiting for a netty worker thread to
change to the subscriber thread pool?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix PUBSUB hang
> ---------------
>
> Key: GEODE-8333
> URL: https://issues.apache.org/jira/browse/GEODE-8333
> Project: Geode
> Issue Type: Bug
> Components: redis
> Reporter: Sarah Abbey
> Assignee: Darrel Schneider
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> PUBSUB hangs with concurrent publishers and subscribers on multiple servers.
> The initial fix is being reverted because it caused a bug in which responses
> to clients could now be out of order.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
