[
https://issues.apache.org/jira/browse/GEODE-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187910#comment-17187910
]
ASF GitHub Bot commented on GEODE-8333:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #5488:
URL: https://github.com/apache/geode/pull/5488#discussion_r480284887
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -247,25 +306,16 @@ private RedisResponse
handleUnAuthenticatedCommand(Command command) {
return response;
}
- public EventLoopGroup getSubscriberGroup() {
- return subscriberGroup;
- }
-
- public void changeChannelEventLoopGroup(EventLoopGroup newGroup) {
- if (newGroup.equals(channel.eventLoop())) {
- // already registered with newGroup
- return;
- }
- channel.deregister().addListener((ChannelFutureListener) future -> {
- newGroup.register(channel).sync();
- });
- }
-
- private void logResponse(RedisResponse response) {
+ private void logResponse(RedisResponse response, String extraMessage,
Throwable cause) {
if (logger.isDebugEnabled() && response != null) {
ByteBuf buf = response.encode(new UnpooledByteBufAllocator(false));
- logger.debug("Redis command returned: {}",
- Command.getHexEncodedString(buf.array(), buf.readableBytes()));
+ if (cause == null) {
+ logger.debug("Redis command returned: {} - {}",
+ Command.getHexEncodedString(buf.array(), buf.readableBytes()),
extraMessage);
+ } else {
+ logger.warn("Redis command FAILED to return: {} - {}",
Review comment:
Changed to `debug`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix PUBSUB hang
> ---------------
>
> Key: GEODE-8333
> URL: https://issues.apache.org/jira/browse/GEODE-8333
> Project: Geode
> Issue Type: Bug
> Components: redis
> Reporter: Sarah Abbey
> Assignee: Darrel Schneider
> Priority: Major
> Labels: pull-request-available
>
> PUBSUB hangs with concurrent publishers and subscribers on multiple servers.
> The initial fix is being reverted because it caused a bug in which responses
> to clients could now be out of order.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
