[ 
https://issues.apache.org/jira/browse/GEODE-8398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180080#comment-17180080
 ] 

ASF GitHub Bot commented on GEODE-8398:
---------------------------------------

echobravopapa commented on a change in pull request #634:
URL: https://github.com/apache/geode-native/pull/634#discussion_r472479203



##########
File path: cppcache/integration/test/SNITest.cpp
##########
@@ -108,41 +112,51 @@ class SNITest : public ::testing::Test {
   }
 
   std::string certificatePassword;
+  boost::filesystem::path clientSslKeysDir;
   boost::filesystem::path currentWorkingDirectory;
+  boost::filesystem::path sniConfigPath;
 };
 
-TEST_F(SNITest, DISABLED_connectViaProxyTest) {
+#if defined(_WIN32)
+TEST_F(SNITest, DISABLE_connectViaProxyTest) {
+#else
+TEST_F(SNITest, connectViaProxyTest) {
+#endif
   const auto clientTruststore =
-      (currentWorkingDirectory /
-       boost::filesystem::path("sni-test-config/geode-config/truststore.jks"));
+      (clientSslKeysDir / boost::filesystem::path("/truststore_sni.pem"));
 
   auto cache = CacheFactory()
-                   .set("log-level", "DEBUG")
+                   .set("log-level", "debug")
+                   .set("log-file", "SNITest.log")
                    .set("ssl-enabled", "true")
                    .set("ssl-truststore", clientTruststore.string())
                    .create();
 
-  auto portString = makeItSo("docker port haproxy");
+  auto portString = runDockerCommand("docker port haproxy");
   auto portNumber = parseProxyPort(portString);
 
   cache.getPoolManager()
       .createFactory()
-      .addLocator("localhost", portNumber)
+      .setSniProxy("localhost", portNumber)
+      .addLocator("locator-maeve", 10334)
       .create("pool");
 
   auto region = cache.createRegionFactory(RegionShortcut::PROXY)
                     .setPoolName("pool")
-                    .create("region");
+                    .create("jellyfish");
 
   region->put("1", "one");
 
   cache.close();
 }
 
-TEST_F(SNITest, connectionFailsTest) {
+#if defined(_WIN32)
+TEST_F(SNITest, DISABLE_connectWithoutProxyFails) {

Review comment:
       aforementioned Docker issues...
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> extend C# (existing, ACE sockets) PoolFactoryAPI to support SNI proxy
> ---------------------------------------------------------------------
>
>                 Key: GEODE-8398
>                 URL: https://issues.apache.org/jira/browse/GEODE-8398
>             Project: Geode
>          Issue Type: New Feature
>          Components: native client
>            Reporter: Ernest Burghardt
>            Priority: Major
>              Labels: pull-request-available
>
> clicache



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to