[
https://issues.apache.org/jira/browse/GEODE-8398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180085#comment-17180085
]
ASF GitHub Bot commented on GEODE-8398:
---------------------------------------
pdxcodemonkey commented on a change in pull request #634:
URL: https://github.com/apache/geode-native/pull/634#discussion_r472481270
##########
File path: cppcache/src/PoolAttributes.cpp
##########
@@ -44,46 +44,13 @@ PoolAttributes::PoolAttributes()
m_subsEnabled(PoolFactory::DEFAULT_SUBSCRIPTION_ENABLED),
m_multiuserSecurityMode(PoolFactory::DEFAULT_MULTIUSER_SECURE_MODE),
m_isPRSingleHopEnabled(PoolFactory::DEFAULT_PR_SINGLE_HOP_ENABLED),
- m_serverGrp(PoolFactory::DEFAULT_SERVER_GROUP) {}
+ m_serverGrp(PoolFactory::DEFAULT_SERVER_GROUP),
+ m_sniProxyPort(0) {}
+
std::shared_ptr<PoolAttributes> PoolAttributes::clone() {
return std::make_shared<PoolAttributes>(*this);
}
-/** Return true if all the attributes are equal to those of other. */
-bool PoolAttributes::operator==(const PoolAttributes& other) const {
Review comment:
At first I refactored it, per our typical practice, because I was in
modifying things there already. Then I checked to see if it was actually in
use anywhere, and discovered it was not, so out it went.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> extend C# (existing, ACE sockets) PoolFactoryAPI to support SNI proxy
> ---------------------------------------------------------------------
>
> Key: GEODE-8398
> URL: https://issues.apache.org/jira/browse/GEODE-8398
> Project: Geode
> Issue Type: New Feature
> Components: native client
> Reporter: Ernest Burghardt
> Priority: Major
> Labels: pull-request-available
>
> clicache
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
