[
https://issues.apache.org/jira/browse/GEODE-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183478#comment-17183478
]
ASF GitHub Bot commented on GEODE-8444:
---------------------------------------
mhansonp commented on a change in pull request #5467:
URL: https://github.com/apache/geode/pull/5467#discussion_r475768556
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/versions/RegionVersionVector.java
##########
@@ -994,13 +994,18 @@ public boolean
isNewerThanOrCanFillExceptionsFor(RegionVersionVector<T> other) {
return false;
}
- private boolean isGCVersionDominatedByOtherHolder(Long gcVersion,
+ private boolean isGCVersionDominatedByOtherHolder(Long gcVersion, Long
requesterGCVersion,
RegionVersionHolder<T> otherHolder) {
if (gcVersion == null || gcVersion.longValue() == 0) {
return true;
} else {
RegionVersionHolder<T> holder = new
RegionVersionHolder<T>(gcVersion.longValue());
- return !holder.isNewerThanOrCanFillExceptionsFor(otherHolder);
+ if (otherHolder == null) {
+ return false;
+ } else {
+ return otherHolder.dominates(holder)
+ && (gcVersion == requesterGCVersion || otherHolder.getVersion() >
gcVersion);
Review comment:
It seems like you are comparing gcversion to rvv in the final
comparison on this line
> otherHolder.getVersion() > gcVersion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> When requester's RVV equals provider's rvvGC, should do fullGII
> ----------------------------------------------------------------
>
> Key: GEODE-8444
> URL: https://issues.apache.org/jira/browse/GEODE-8444
> Project: Geode
> Issue Type: Improvement
> Reporter: Xiaojian Zhou
> Assignee: Xiaojian Zhou
> Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> In current design, when requester's RVV equals provider's rvvGC, we treated
> as dominated.
> But if the last operation at provider is a destroy and the tombstone is GCed
> when requester is offline, the provider lost the information about this key
> when GII. So we should do fullGII instead of deltaGII in this case.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
