[
https://issues.apache.org/jira/browse/GEODE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184792#comment-17184792
]
ASF GitHub Bot commented on GEODE-8447:
---------------------------------------
jchen21 commented on a change in pull request #5469:
URL: https://github.com/apache/geode/pull/5469#discussion_r476884043
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/json/AbstractJSONFormatter.java
##########
@@ -94,6 +94,8 @@ public AbstractJSONFormatter(int maxCollectionElements, int
serializationDepth,
// register the custom module
mapper.registerModule(mapperModule);
+ // to support jdk8 java.time if jackson-datatype-jsr310 is included in the
classpath
Review comment:
That means if the user uses ` java.time.LocalTime`, it also requires
`jackson-datatype-jsr310` to format it properly. However, this dependency is
for `integrationTestRuntimeOnly` in `build.gradle`. In `expected-pom.xml`, its
scope is `compile`. We might have to check the open source license
requirements for new third party dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Pulse should localize “java.util.Date” in the displayed query result
> --------------------------------------------------------------------
>
> Key: GEODE-8447
> URL: https://issues.apache.org/jira/browse/GEODE-8447
> Project: Geode
> Issue Type: Bug
> Components: management
> Affects Versions: 1.12.0
> Reporter: Jinmei Liao
> Assignee: Jinmei Liao
> Priority: Major
> Labels: pull-request-available
> Attachments: CreatedOn-lastUpdated.JPG, Date-GF96.JPG
>
>
> In previous versions of Geode, Pulse used to show Dates in localized string,
> now it's not.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
