[
https://issues.apache.org/jira/browse/GEODE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184871#comment-17184871
]
ASF GitHub Bot commented on GEODE-8447:
---------------------------------------
jinmeiliao commented on a change in pull request #5469:
URL: https://github.com/apache/geode/pull/5469#discussion_r477000079
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/json/AbstractJSONFormatter.java
##########
@@ -94,6 +94,8 @@ public AbstractJSONFormatter(int maxCollectionElements, int
serializationDepth,
// register the custom module
mapper.registerModule(mapperModule);
+ // to support jdk8 java.time if jackson-datatype-jsr310 is included in the
classpath
Review comment:
It's only required for testing. If user's domain object includes that
type and they would like it to be formatted correctly, then they will need to
include the jar in the classpath (Geode is not shipping with it). We are just
calling the `findAndRegisterModuel` in case users have the jar in the classpath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Pulse should localize “java.util.Date” in the displayed query result
> --------------------------------------------------------------------
>
> Key: GEODE-8447
> URL: https://issues.apache.org/jira/browse/GEODE-8447
> Project: Geode
> Issue Type: Bug
> Components: management
> Affects Versions: 1.12.0
> Reporter: Jinmei Liao
> Assignee: Jinmei Liao
> Priority: Major
> Labels: pull-request-available
> Attachments: CreatedOn-lastUpdated.JPG, Date-GF96.JPG
>
>
> In previous versions of Geode, Pulse used to show Dates in localized string,
> now it's not.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
