[
https://issues.apache.org/jira/browse/GEODE-8786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259748#comment-17259748
]
ASF GitHub Bot commented on GEODE-8786:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #5875:
URL: https://github.com/apache/geode/pull/5875#discussion_r552652990
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSetCommandsFunctionExecutor.java
##########
@@ -37,18 +37,22 @@ public RedisSetCommandsFunctionExecutor(
super(helper);
}
- private RedisSet getRedisSet(ByteArrayWrapper key) {
- return helper.getRedisSet(key);
+ private RedisSet getRedisSet(ByteArrayWrapper key, boolean updateStats) {
Review comment:
This is probably a nit, but for consistency can this class be consistent
with the other `*FunctionExecutor`s and either introduce an overloaded
`getRedisSet` which updates stats. Or remove the other classes' duplicate
`getRedisSet` and just have one method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> INFO command hit/miss ratios should match native Redis
> ------------------------------------------------------
>
> Key: GEODE-8786
> URL: https://issues.apache.org/jira/browse/GEODE-8786
> Project: Geode
> Issue Type: Bug
> Components: redis
> Affects Versions: 1.14.0
> Reporter: Raymond Ingles
> Priority: Major
> Labels: pull-request-available
>
> Current hit/miss ratios for Geode Redis stats do not match those for native
> Redis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
