[
https://issues.apache.org/jira/browse/GEODE-8786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259879#comment-17259879
]
ASF GitHub Bot commented on GEODE-8786:
---------------------------------------
jhutchison commented on a change in pull request #5875:
URL: https://github.com/apache/geode/pull/5875#discussion_r552806036
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/server/AbstractHitsMissesIntegrationTest.java
##########
@@ -286,90 +306,312 @@ public void testHscan() {
runCommandAndAssertHitsAndMisses("hash", (k, v) -> jedis.hscan(k, v));
}
+ @Test
+ public void testHMSet() {
+ Map<String, String> info = getInfo(jedis);
+ Long currentHits = Long.parseLong(info.get(HITS));
+ Long currentMisses = Long.parseLong(info.get(MISSES));
+
+ Map<String, String> map = new HashMap<>();
+ map.put("key1", "value1");
+ map.put("key2", "value2");
+
+ jedis.hmset("key", map);
Review comment:
done- had to create one with a new signature- not sure if this is the
best signature...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> INFO command hit/miss ratios should match native Redis
> ------------------------------------------------------
>
> Key: GEODE-8786
> URL: https://issues.apache.org/jira/browse/GEODE-8786
> Project: Geode
> Issue Type: Bug
> Components: redis
> Affects Versions: 1.14.0
> Reporter: Raymond Ingles
> Priority: Major
> Labels: pull-request-available
>
> Current hit/miss ratios for Geode Redis stats do not match those for native
> Redis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
