[
https://issues.apache.org/jira/browse/GEODE-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376813#comment-17376813
]
ASF GitHub Bot commented on GEODE-8891:
---------------------------------------
mreddington commented on a change in pull request #830:
URL: https://github.com/apache/geode-native/pull/830#discussion_r665669483
##########
File path: cppcache/src/ThinClientRegion.cpp
##########
@@ -589,7 +595,7 @@ std::shared_ptr<SelectResults> ThinClientRegion::query(
}
std::string squery;
- if (std::regex_search(predicate, PREDICATE_IS_FULL_QUERY_REGEX)) {
+ if (std::regex_search(predicate, IsFullQueryRegex::instance())) {
Review comment:
Why wrap the static const in a singleton? That sounds like an even more
complicated solution. You could have just made this regex a local const
variable. Who cares about runtime performance when this isn't where we're slow?
The class still needs to be initialized at runtime anyway, as you've found out
the hard way, and instead of burdening the whole test harness with the
initialization of a global static, you could isolate that initialization to the
instantiation of this test when it's ran.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Convert remaining singletons to Meyers pattern
> ----------------------------------------------
>
> Key: GEODE-8891
> URL: https://issues.apache.org/jira/browse/GEODE-8891
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> As a developer, it is to my advantage to preemptively pay technical debt when
> I can, especially if said debt has potentially subtle bugs. Geode Native
> still has several poortly-written singleton objects in legacy code, and as
> we've just seen with the rewrite of EventId for GEODE-8887, these can
> introduce very strange behavior in a multi-threaded app. We need to identify
> any of these remaining, and clean them up like we did for EventId.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
