[
https://issues.apache.org/jira/browse/GEODE-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376892#comment-17376892
]
ASF GitHub Bot commented on GEODE-8891:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #830:
URL: https://github.com/apache/geode-native/pull/830#discussion_r665762038
##########
File path: cppcache/src/ThinClientRegion.cpp
##########
@@ -589,7 +595,7 @@ std::shared_ptr<SelectResults> ThinClientRegion::query(
}
std::string squery;
- if (std::regex_search(predicate, PREDICATE_IS_FULL_QUERY_REGEX)) {
+ if (std::regex_search(predicate, IsFullQueryRegex::instance())) {
Review comment:
Given this value doesn't have any use outside this method I could agree
with making it a local const. There is technically no different between that
and the proposed implementation other than encapsulation of the const logic in
the additional method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Convert remaining singletons to Meyers pattern
> ----------------------------------------------
>
> Key: GEODE-8891
> URL: https://issues.apache.org/jira/browse/GEODE-8891
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> As a developer, it is to my advantage to preemptively pay technical debt when
> I can, especially if said debt has potentially subtle bugs. Geode Native
> still has several poortly-written singleton objects in legacy code, and as
> we've just seen with the rewrite of EventId for GEODE-8887, these can
> introduce very strange behavior in a multi-threaded app. We need to identify
> any of these remaining, and clean them up like we did for EventId.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
