[
https://issues.apache.org/jira/browse/GEODE-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746472#comment-14746472
]
ASF subversion and git services commented on GEODE-291:
-------------------------------------------------------
Commit 646affa04868f3fd50f7d24018d98ba2fa96ac47 in incubator-geode's branch
refs/heads/feature/GEODE-291 from [[email protected]]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=646affa ]
GEODE-291: Improve debugging of test.process wrapper and readers.
Remove unused methods and variables.
Change waitFor() to match the Process.waitFor(long, TimeUnit) method in
JDK 1.8 (this still compiles/works under 1.7). Pass in timeout
parameters from ProcessWrapper instead of hardcoding it.
Separate waitFor() into waitFor(long, TimeUnit) and start(). Previously
waitFor() was performing both of these actions.
Improve debugging by: 1) adding minor lifecycle to ProcessOutputReader,
2) include command string in stack trace of ProcessStreamReader. This
will allow me to identify the source of GEODE-291 -- once I've
identified it then I'll determine if there are any further changes that
need to be made. If it the output is truly not a real issue then I'll
suppress the stack trace from being printed.
> integrationTest target should not print a ProcessStreamReader stack trace to
> stderr
> -----------------------------------------------------------------------------------
>
> Key: GEODE-291
> URL: https://issues.apache.org/jira/browse/GEODE-291
> Project: Geode
> Issue Type: Bug
> Affects Versions: 1.0.0-incubating
> Reporter: Kirk Lund
> Assignee: Kirk Lund
>
> One of the IntegrationTests is printing a stack trace to stderr. This should
> either be suppressed or the test causing it should stop the reader thread
> more gracefully.
> {noformat}
> :gemfire-core:integrationTestjava.lang.Throwable
> at
> com.gemstone.gemfire.test.process.ProcessStreamReader.start(ProcessStreamReader.java:46)
> at
> com.gemstone.gemfire.test.process.ProcessOutputReader.waitFor(ProcessOutputReader.java:31)
> at
> com.gemstone.gemfire.test.process.ProcessWrapper.start(ProcessWrapper.java:314)
> at
> com.gemstone.gemfire.test.process.ProcessWrapper.access$000(ProcessWrapper.java:31)
> at
> com.gemstone.gemfire.test.process.ProcessWrapper$1.run(ProcessWrapper.java:244)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.io.IOException: Stream closed
> at
> java.io.BufferedInputStream.getBufIfOpen(BufferedInputStream.java:162)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:272)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
> at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:283)
> at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:325)
> at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:177)
> at java.io.InputStreamReader.read(InputStreamReader.java:184)
> at java.io.BufferedReader.fill(BufferedReader.java:154)
> at java.io.BufferedReader.readLine(BufferedReader.java:317)
> at java.io.BufferedReader.readLine(BufferedReader.java:382)
> at
> com.gemstone.gemfire.test.process.ProcessStreamReader.run(ProcessStreamReader.java:54)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
