[
https://issues.apache.org/jira/browse/GEODE-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053825#comment-15053825
]
ASF subversion and git services commented on GEODE-291:
-------------------------------------------------------
Commit fe295940c2c61a97c84ae333574e80001962ba15 in incubator-geode's branch
refs/heads/develop from [[email protected]]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=fe29594 ]
GEODE-291: Prevent stderr noise from com.gemstone.gemfire.test.process
Change classes in com.gemstone.gemfire.test.process package:
* Remove unused methods and variables..
* Change waitFor() to match the Process.waitFor(long, TimeUnit) method in
JDK 1.8. Pass in timeout parameters from ProcessWrapper instead of
hardcoding it.
* Separate waitFor() into waitFor(long, TimeUnit) and start(). Previously
waitFor() was performing both of these actions.
* Improve debugging by: 1) adding minor lifecycle to ProcessOutputReader,
2) include command string in stack trace of ProcessStreamReader. This
enabled identification of the source of unwanted stderr output.
Change DistributedSystem to enable testing:
* Change DistributedSystem to enable better unit testing by allowing tests
to provide different locations for gemfire.properties with
gemfirePropertyFile. Make same changes for gfsecurity.properties and
gemfireSecurityPropertyFile.
* Create unit and integration tests for DistributedSystem class.
Change tests that use com.gemstone.gemfire.test.process package:
* Use DistributedSystem.PROPERTIES_FILE_PROPERTY to override location of
gemfire.properties.
* Separate integration tests from UnitTest files to IntegrationTests.
* Add and use Catch-Exception for better unit testing.
* Remove unused code and class.
> integrationTest target should not print a ProcessStreamReader stack trace to
> stderr
> -----------------------------------------------------------------------------------
>
> Key: GEODE-291
> URL: https://issues.apache.org/jira/browse/GEODE-291
> Project: Geode
> Issue Type: Bug
> Components: tests
> Affects Versions: 1.0.0-incubating
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Labels: ci
> Fix For: 1.0.0-incubating
>
>
> One of the IntegrationTests is printing a stack trace to stderr. This should
> either be suppressed or the test causing it should stop the reader thread
> more gracefully.
> {noformat}
> :gemfire-core:integrationTestjava.lang.Throwable
> at
> com.gemstone.gemfire.test.process.ProcessStreamReader.start(ProcessStreamReader.java:46)
> at
> com.gemstone.gemfire.test.process.ProcessOutputReader.waitFor(ProcessOutputReader.java:31)
> at
> com.gemstone.gemfire.test.process.ProcessWrapper.start(ProcessWrapper.java:314)
> at
> com.gemstone.gemfire.test.process.ProcessWrapper.access$000(ProcessWrapper.java:31)
> at
> com.gemstone.gemfire.test.process.ProcessWrapper$1.run(ProcessWrapper.java:244)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.io.IOException: Stream closed
> at
> java.io.BufferedInputStream.getBufIfOpen(BufferedInputStream.java:162)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:272)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
> at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:283)
> at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:325)
> at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:177)
> at java.io.InputStreamReader.read(InputStreamReader.java:184)
> at java.io.BufferedReader.fill(BufferedReader.java:154)
> at java.io.BufferedReader.readLine(BufferedReader.java:317)
> at java.io.BufferedReader.readLine(BufferedReader.java:382)
> at
> com.gemstone.gemfire.test.process.ProcessStreamReader.run(ProcessStreamReader.java:54)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
