[ 
https://issues.apache.org/jira/browse/GUACAMOLE-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253849#comment-17253849
 ] 

Mike Jumper commented on GUACAMOLE-1241:
----------------------------------------

>From {{git bisect}}:

{code:none}
[mjumper@dev-mjumper guacamole-server]$ git bisect bad
2c86e20ab90238bc90f4979e876b3ff8a1d25e64 is the first bad commit
commit 2c86e20ab90238bc90f4979e876b3ff8a1d25e64
Author: Michael Jumper <[email protected]>
Date:   Wed Oct 28 20:23:37 2020 -0700

    GUACAMOLE-1181: Free wStream after send is complete/cancelled.

 src/protocols/rdp/channels/common-svc.c                     |  7 +++----
 src/protocols/rdp/plugins/guac-common-svc/guac-common-svc.c | 13 +++++++++----
 2 files changed, 12 insertions(+), 8 deletions(-)
[mjumper@dev-mjumper guacamole-server]$ 
{code}

> Immediate double-free upon connecting to Windows RDP
> ----------------------------------------------------
>
>                 Key: GUACAMOLE-1241
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-1241
>             Project: Guacamole
>          Issue Type: Bug
>          Components: RDP
>    Affects Versions: 1.3.0
>            Reporter: Mike Jumper
>            Assignee: Mike Jumper
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> Regression testing against {{staging/1.3.0}} using the Docker image, I am 
> seeing an immediate disconnect due to a double-free when attempting to 
> connect to Windows RDP:
> {code:none}
> ...
> guacd[24698]: INFO:   Loading keymap "base"
> guacd[24698]: INFO:   Loading keymap "en-us-qwerty"
> guacd[24698]: INFO:   Connected to RDPDR 1.13 as client 0x0005
> free(): double free detected in tcache 2
> guacd[6]: INFO:       Connection "$e6955582-c6f2-4912-a4bd-a3ffee002cd1" 
> removed.
> {code}
> With there being a few memory-related RDP changes in the upcoming release 
> (and with no such issues in 1.2.0), I suspect this is a regression.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to