[ 
https://issues.apache.org/jira/browse/GUACAMOLE-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253883#comment-17253883
 ] 

Mike Jumper commented on GUACAMOLE-1241:
----------------------------------------

The version of FreeRDP currently packaged by Debian stable is not a FreeRDP 
release, but rather [commit 
2693389|https://github.com/FreeRDP/FreeRDP/commit/2693389a103394e035edc2a01055ca2c9ccccb21].
 That commit comes after 2.0.0-rc4 (hence the 2.0.0-dev5 designation), but is 
not recent enough to incorporate the changes of [commit 
1b78b59|https://github.com/FreeRDP/FreeRDP/commit/1b78b599263033e3527903e33b3dae84031425ec]
 that removed the automatic free. There is no way to know from version number 
alone whether this is the case (hence the build warning).

I don't think there is a safe way to resolve this that would allow the Debian 
version of the package to be supported. Adding a specific exception for the git 
commit used by this particular version of Debian feels excessive. I think the 
best path forward would be to:

# Expect Debian to (eventually?) package a version of FreeRDP that is a 
specific RC or version, not a development snapshot.
# Switch over to a different base image for the guacd Docker image that is 
known to provide a package for FreeRDP that is based off a release (Ubuntu? 
Maybe?), not a development snapshot.

Users of Debian stable would need to, for the time being:

* Build guacamole-server with {{CFLAGS="-DFREERDP_SVC_CORE_FREES_WSTREAM=1"}}, 
to effectively override the result of the FreeRDP version test.
* Kindly poke the package managers to consider using only releases for 
packaging, as the behavior of development snapshots cannot be predicted.

> Immediate double-free upon connecting to Windows RDP
> ----------------------------------------------------
>
>                 Key: GUACAMOLE-1241
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-1241
>             Project: Guacamole
>          Issue Type: Bug
>          Components: RDP
>    Affects Versions: 1.3.0
>            Reporter: Mike Jumper
>            Assignee: Mike Jumper
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> Regression testing against {{staging/1.3.0}} using the Docker image, I am 
> seeing an immediate disconnect due to a double-free when attempting to 
> connect to Windows RDP:
> {code:none}
> ...
> guacd[24698]: INFO:   Loading keymap "base"
> guacd[24698]: INFO:   Loading keymap "en-us-qwerty"
> guacd[24698]: INFO:   Connected to RDPDR 1.13 as client 0x0005
> free(): double free detected in tcache 2
> guacd[6]: INFO:       Connection "$e6955582-c6f2-4912-a4bd-a3ffee002cd1" 
> removed.
> {code}
> With there being a few memory-related RDP changes in the upcoming release 
> (and with no such issues in 1.2.0), I suspect this is a regression.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to