[
https://issues.apache.org/jira/browse/GUACAMOLE-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410538#comment-17410538
]
Nick Couchman edited comment on GUACAMOLE-1416 at 9/6/21, 11:17 AM:
--------------------------------------------------------------------
[~RyanCai]: Yep - you can fork the repo and create a pull request - I'd also
recommend creating a branch specifically for the issue. Both pull request and
any commit messages should have the Jira issue prepended (GUACAMOLE-1416:
<COMMIT MESSAGE>), and just make sure your changes are consistent with the
style used throughout the code (4-space tab stops, etc.).
Full contribution guidelines are here:
http://guacamole.apache.org/open-source/
was (Author: [email protected]):
[~RyanCai]: Yep - you can fork the repo and create a pull request - I'd also
recommend creating a branch specifically for the issue. Both pull request and
any commit messages should have the Jira issue prepended (GUACAMOLE-1416:
<COMMIT MESSAGE>), and just make sure your changes are consistent with the
style used throughout the code (4-space tab stops, etc.).
> An improper locking bug(e.g., resource leak) due to unreleased lock
> -------------------------------------------------------------------
>
> Key: GUACAMOLE-1416
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-1416
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole, guacamole-server
> Affects Versions: 1.3.0
> Reporter: Ryan Cai
> Priority: Minor
>
> In the below codes, the lock
> +pthread_mutex_lock(&(ssh_client->term_channel_lock))+ , the resource, can
> not be correctly released if
> +libssh2_keepalive_send(ssh_client->session->session, &timeout) >+ +0+.
>
> Locations:
> https://github.com/apache/guacamole-server/blob/b2ae2fdf003a6854ac42877ce0fce8e88ceb038a/src/protocols/ssh/ssh.c#L424-L453
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
