[
https://issues.apache.org/jira/browse/HAWQ-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004942#comment-15004942
]
ASF GitHub Bot commented on HAWQ-44:
------------------------------------
Github user entong commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/92#discussion_r44848062
--- Diff: src/backend/commands/analyze.c ---
@@ -1217,18 +1214,18 @@ static float4 estimateSampleSize(Oid relationOid,
const char *attributeName, flo
* read_only - is it a read-only call?
* tcount - execution tuple-count limit, or 0 for none
* callbackFn - callback function to be executed once SPI is done.
- * clientData - argument to call back function (usually pointer to
data-structure
+ * clientData - argument to call back function (usually pointer to
data-structure
* that the callback function populates).
- *
+ *
*/
-static void spiExecuteWithCallback(
+void spiExecuteWithCallback(
const char *src,
bool read_only,
long tcount,
spiCallback callbackFn,
void *clientData)
{
- bool connected = false;
+ volatile bool connected = false; /* needs to be volatile when accessed
by PG_CATCH */
--- End diff --
thanks!
> Advanced statistics for PXF tables
> ----------------------------------
>
> Key: HAWQ-44
> URL: https://issues.apache.org/jira/browse/HAWQ-44
> Project: Apache HAWQ
> Issue Type: New Feature
> Components: PXF
> Reporter: Noa Horn
> Assignee: Noa Horn
> Labels: Performance
>
> PXF will get full statistics on a table using sampling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
