[
https://issues.apache.org/jira/browse/HAWQ-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003176#comment-15003176
]
ASF GitHub Bot commented on HAWQ-44:
------------------------------------
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/92#discussion_r44730180
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/BridgeOutputBuilder.java
---
@@ -216,10 +245,53 @@ void fillText(List<OneField> recFields) throws
BadRecordException {
int type = fld.type;
Object val = fld.val;
if (DataType.get(type) == DataType.BYTEA) {// from
LineBreakAccessor
- output = new BufferWritable((byte[]) val);
+ if (samplingEnabled) {
+ convertTextDataToLines((byte[]) val);
+ } else {
+ output = new BufferWritable((byte[]) val);
+ outputList.add(output); // TODO break output into lines
+ }
} else { // from QuotedLineBreakAccessor
String textRec = (String) val;
output = new Text(textRec + "\n");
+ outputList.add(output);
+ }
+ }
+
+ void convertTextDataToLines(byte[] val) {
--- End diff --
Add a comment to this function explaining the purpose of this either here
or when it is invoked for sampling
> Advanced statistics for PXF tables
> ----------------------------------
>
> Key: HAWQ-44
> URL: https://issues.apache.org/jira/browse/HAWQ-44
> Project: Apache HAWQ
> Issue Type: New Feature
> Components: PXF
> Reporter: Noa Horn
> Assignee: Noa Horn
> Labels: Performance
>
> PXF will get full statistics on a table using sampling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
