[
https://issues.apache.org/jira/browse/HAWQ-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141863#comment-15141863
]
ASF GitHub Bot commented on HAWQ-404:
-------------------------------------
Github user hsyuan commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/337#discussion_r52538930
--- Diff: src/include/gpopt/gpdbwrappers.h ---
@@ -303,6 +303,9 @@ namespace gpdb {
// find the oid of the root partition given partition oid belongs to
Oid OidRootPartition(Oid oid);
+ // find the number of partitions for a given root relation
+ int INumberPartitions(Oid oid);
+
--- End diff --
Looked at this function again, `UlLeafPartitions` returns the number of
leaf partitions, it only accept oid of root partitioned table.
Both function uses `countLeafPartTables` to count the number of leaf
partitions.
The only difference is that `INumberPartitions ` can accept non root
partition oid, just return 0 when it is neither a root partition table nor a
partition table.
In fact, we can get rid of INumberPartitions.
> Add sort during INSERT of append only row oriented partition tables
> -------------------------------------------------------------------
>
> Key: HAWQ-404
> URL: https://issues.apache.org/jira/browse/HAWQ-404
> Project: Apache HAWQ
> Issue Type: Improvement
> Reporter: Haisheng Yuan
> Assignee: Lei Chang
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
