[
https://issues.apache.org/jira/browse/HAWQ-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141881#comment-15141881
]
ASF GitHub Bot commented on HAWQ-404:
-------------------------------------
Github user hsyuan commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/337#discussion_r52539723
--- Diff: src/backend/gpopt/translate/CTranslatorRelcacheToDXL.cpp ---
@@ -652,6 +653,10 @@ CTranslatorRelcacheToDXL::Pmdrel
erelstorage =
IMDRelation::ErelstorageAppendOnlyParquet;
}
}
+
+ // get number of leaf partitions
+ ulLeafPartitions = gpdb::INumberPartitions(oid);
+
--- End diff --
```cpp
ulLeafPartitions = 0;
if (gpdb::FRelPartIsRoot(oid))
{
ulLeafPartitions = gpdb::UlLeafPartitions(oid);
}
```
I recommend we change to this code snippet, thus we can get rid of
INumberPartitions.
> Add sort during INSERT of append only row oriented partition tables
> -------------------------------------------------------------------
>
> Key: HAWQ-404
> URL: https://issues.apache.org/jira/browse/HAWQ-404
> Project: Apache HAWQ
> Issue Type: Improvement
> Reporter: Haisheng Yuan
> Assignee: Lei Chang
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
