Github user wengyanqing commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/835#discussion_r73815359
  
    --- Diff: src/backend/utils/misc/guc.c ---
    @@ -12216,7 +12216,36 @@ ProcessGUCArray(ArrayType *array, GucSource source)
                 * GPSQL needs to dispatch the database/user config to segments.
                 */
                if (Gp_role == GP_ROLE_DISPATCH)
    -                   appendStringInfo(&MyProcPort->override_options, "-c 
%s=%s ", name, value);
    +           {
    --- End diff --
    
    It's better to make a function to handle this common logic which process 
the special char. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to