Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/835#discussion_r73816040
--- Diff: src/backend/utils/misc/guc.c ---
@@ -12216,7 +12216,36 @@ ProcessGUCArray(ArrayType *array, GucSource source)
* GPSQL needs to dispatch the database/user config to segments.
*/
if (Gp_role == GP_ROLE_DISPATCH)
- appendStringInfo(&MyProcPort->override_options, "-c
%s=%s ", name, value);
+ {
+ unsigned int j, start, size;
+ char *temp;
+
+ size = 256;
+ temp = guc_malloc(ERROR, size + 8);
+
+ j = 0;
+ for (start = 0; start < strlen(value); ++start)
+ {
+ if (j == size)
+ {
--- End diff --
I think this part of code has kind of duplication with the code segment in
executormgr.c?? Shall we extract this out?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
