Github user GodenYao commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/873#discussion_r77103957
--- Diff:
pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/utilities/EnumHawqType.java
---
@@ -43,37 +45,40 @@ public void serialize(EnumHawqType value, JsonGenerator
generator,
*/
@JsonSerialize(using = EnumHawqTypeSerializer.class)
public enum EnumHawqType {
- Int2Type("int2"),
- Int4Type("int4"),
- Int8Type("int8"),
- Float4Type("float4"),
- Float8Type("float8"),
- TextType("text"),
- VarcharType("varchar", (byte) 1, true),
- ByteaType("bytea"),
- DateType("date"),
- TimestampType("timestamp"),
- BoolType("bool"),
- NumericType("numeric", (byte) 2, true),
- BpcharType("bpchar", (byte) 1, true);
+ Int2Type("int2", DataType.SMALLINT),
+ Int4Type("int4", DataType.INTEGER),
+ Int8Type("int8", DataType.BIGINT),
+ Float4Type("float4", DataType.REAL),
+ Float8Type("float8", DataType.FLOAT8),
+ TextType("text", DataType.TEXT),
+ VarcharType("varchar", DataType.VARCHAR, (byte) 1, false),
+ ByteaType("bytea", DataType.BYTEA),
+ DateType("date", DataType.DATE),
+ TimestampType("timestamp", DataType.TIMESTAMP),
+ BoolType("bool", DataType.BOOLEAN),
+ NumericType("numeric", DataType.NUMERIC, (byte) 2, false),
+ BpcharType("bpchar", DataType.BPCHAR, (byte) 1, false),
--- End diff --
yes, if omitting the modifier, bpchar will be dynamic length
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
