Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/873#discussion_r77741194
--- Diff:
pxf/pxf-service/src/main/java/org/apache/hawq/pxf/service/io/GPDBWritable.java
---
@@ -832,40 +832,10 @@ private boolean isTextForm(int type) {
* @return type name
*/
public static String getTypeName(int oid) {
- switch (DataType.get(oid)) {
- case BOOLEAN:
- return "BOOLEAN";
- case BYTEA:
- return "BYTEA";
- case CHAR:
- return "CHAR";
- case BIGINT:
- return "BIGINT";
- case SMALLINT:
- return "SMALLINT";
- case INTEGER:
- return "INTEGER";
- case TEXT:
- return "TEXT";
- case REAL:
- return "REAL";
- case FLOAT8:
- return "FLOAT8";
- case BPCHAR:
- return "BPCHAR";
- case VARCHAR:
- return "VARCHAR";
- case DATE:
- return "DATE";
- case TIME:
- return "TIME";
- case TIMESTAMP:
- return "TIMESTAMP";
- case NUMERIC:
- return "NUMERIC";
- default:
- return "TEXT";
- }
+ DataType type = DataType.get(oid);
--- End diff --
Earlier we handled the default case as "TEXT". With this change we will get
"UNSUPPORTED_TYPE"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
