Github user sansanichfb commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/895#discussion_r78458135
  
    --- Diff: 
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/EnumHiveToHawqType.java
 ---
    @@ -152,6 +153,33 @@ public int compare(EnumHiveToHawqType a,
         }
     
         /**
    +     *
    +     * @return full type name including modifiers. eg: varchar(3)
    +     */
    +    public static String getFullTypeName(EnumHiveToHawqType 
hiveToHawqType, Integer[] modifiers) {
    +        hiveToHawqType.getTypeName();
    --- End diff --
    
    Why do we call it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to