Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/895#discussion_r78458437
--- Diff:
pxf/pxf-hive/src/main/java/org/apache/hawq/pxf/plugins/hive/utilities/EnumHiveToHawqType.java
---
@@ -152,6 +153,33 @@ public int compare(EnumHiveToHawqType a,
}
/**
+ *
+ * @return full type name including modifiers. eg: varchar(3)
+ */
+ public static String getFullTypeName(EnumHiveToHawqType
hiveToHawqType, Integer[] modifiers) {
+ hiveToHawqType.getTypeName();
+ if(modifiers != null && modifiers.length > 0) {
+ String modExpression = hiveToHawqType.getSplitExpression();
+ StringBuilder fullType = new
StringBuilder(hiveToHawqType.typeName);
+ Character start = modExpression.charAt(1);
+ Character separator = modExpression.charAt(2);
+ Character end = modExpression.charAt(modExpression.length()-2);
+ fullType.append(start);
+ int index = 0;
+ for (Integer modifier : modifiers) {
+ if(index++ > 0) {
+ fullType.append(separator);
+ }
+ fullType.append(modifier);
+ }
+ fullType.append(end);
+ return fullType.toString();
+ } else {
+ return hiveToHawqType.typeName;
--- End diff --
Call getter instead of field?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
