Github user paul-guo- commented on a diff in the pull request:
    --- Diff: src/backend/resourcemanager/requesthandler.c ---
    @@ -627,7 +627,11 @@ bool handleRMSEGRequestIMAlive(void **arg)
        fts_client_ip_len = strlen(fts_client_ip);
        inet_aton(fts_client_ip, &fts_client_addr);
        fts_client_host = gethostbyaddr(&fts_client_addr, 4, AF_INET);
    -   Assert(fts_client_host != NULL);
    +   if (fts_client_host == NULL)
    +   {
    +           elog(WARNING, "Failed to reverse DNS lookup for ip %s.", 
    +           return true;
    +   }
    --- End diff --
    If it is easy to modify we could use the replacement of gethostbyaddr().
    By the way, why need to quit after "reverse dns lookup" failure. Should not
    an IP address work also?
           The gethostbyname*() and gethostbyaddr*()  functions  are  obsolete. 
           should use getaddrinfo(3) and getnameinfo(3) instead.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to