Github user kavinderd commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/906#discussion_r83101774
--- Diff:
pxf/pxf-hbase/src/main/java/org/apache/hawq/pxf/plugins/hbase/HBaseFilterBuilder.java
---
@@ -122,25 +130,23 @@ public Filter getFilterObject(String filterString)
throws Exception {
public Object build(FilterParser.Operation opId,
Object leftOperand,
Object rightOperand) throws Exception {
- if (leftOperand instanceof Filter) {
- if (opId != FilterParser.Operation.HDOP_AND ||
- !(rightOperand instanceof Filter)) {
- throw new Exception("Only AND is allowed between compound
expressions");
- }
-
- return handleCompoundOperations((Filter) leftOperand, (Filter)
rightOperand);
- }
-
- if (!(rightOperand instanceof FilterParser.Constant)) {
- throw new Exception("expressions of column-op-column are not
supported");
- }
// Assume column is on the left
return handleSimpleOperations(opId,
(FilterParser.ColumnIndex) leftOperand,
(FilterParser.Constant) rightOperand);
}
+ @Override
+ public Object build(FilterParser.LogicalOperation opId, Object
leftOperand, Object rightOperand) {
+ return handleCompoundOperations(opId, (Filter) leftOperand,
(Filter) rightOperand);
+ }
+
+ @Override
+ public Object build(FilterParser.LogicalOperation opId, Object
leftOperand) {
+ return null;
--- End diff --
Yeah, HBase doesn't support NOT operations. I don't think this method will
ever be invoked in the Hbase case because I already return null when filtering
a Hbase filter with 'l2' as an op code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
