Github user interma commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1093#discussion_r96560410
  
    --- Diff: depends/libhdfs3/src/client/Hdfs.cpp ---
    @@ -989,8 +989,31 @@ int hdfsSetReplication(hdfsFS fs, const char * path, 
int16_t replication) {
         return -1;
     }
     
    +static void ConstructHdfsEncryptionZoneInfo(hdfsEncryptionZoneInfo * 
infoEn,
    +                                  std::vector<Hdfs::EncryptionZoneInfo> & 
enStatus) {
    +    size_t size = enStatus.size();
    +
    +    for (size_t i = 0; i < size; ++i) {
    +        infoEn[i].mSuite = enStatus[i].getSuite();
    +        infoEn[i].mCryptoProtocolVersion = 
enStatus[i].getCryptoProtocolVersion();
    +        infoEn[i].mId = enStatus[i].getId();
    +        infoEn[i].mPath = Strdup(enStatus[i].getPath());
    +        infoEn[i].mKeyName = Strdup(enStatus[i].getKeyName());
    +    }
    +}
    +
    +static void ConstructHdfsEncryptionFileInfo(hdfsEncryptionFileInfo * 
infoEn,
    +                                  Hdfs::FileEncryptionInfo* enStatus) {
    +    infoEn->mSuite = enStatus->getSuite();
    +    infoEn->mCryptoProtocolVersion = enStatus->getCryptoProtocolVersion();
    +    infoEn->mKey = Strdup(enStatus->getKey());
    +    infoEn->mKeyName = Strdup(enStatus->getKeyName());
    +    infoEn->mIv = Strdup(enStatus->getIv());
    --- End diff --
    
    Should to confirm whether IV material contains \0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to