Github user interma commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1093#discussion_r96584985
--- Diff: depends/libhdfs3/src/client/hdfs.h ---
@@ -482,6 +482,30 @@ int hdfsCreateDirectory(hdfsFS fs, const char * path);
int hdfsSetReplication(hdfsFS fs, const char * path, int16_t replication);
/**
+ * hdfsEncryptionZoneInfo- Information about an encryption zone.
+ */
+typedef struct {
+ int mSuite; /* the suite of encryption zone */
+ int mCryptoProtocolVersion; /* the version of crypto protocol */
+ int64_t mId; /* the id of encryption zone */
+ char * mPath; /* the path of encryption zone */
+ char * mKeyName; /* the key name of encryption zone */
+} hdfsEncryptionZoneInfo;
+
+
+/**
+ * hdfsEncryptionFileInfo - Information about an encryption file/directory.
+ */
+typedef struct {
+ int mSuite; /* the suite of encryption file/directory */
+ int mCryptoProtocolVersion; /* the version of crypto protocol */
+ char * mKey; /* the key of encryption file/directory */
+ char * mKeyName; /* the key name of encryption file/directory */
+ char * mIv; /* the iv of encryption file/directory */
+ char * mEzKeyVersionName; /* the version encryption file/directory */
--- End diff --
The 4 `char *` field, change to array(e.g. `char mKey[16];` ) or new a
buffer(e.g. call `Strdup()` ) is better?
Don't change is also ok, and should use them carefully in future code
(avoid the space of their point is invalid).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
