Github user stanlyxiang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1171#discussion_r106078042
--- Diff: src/test/feature/Ranger/test_ranger.cpp ---
@@ -24,19 +24,34 @@
#include "lib/command.h"
#include "lib/gpfdist.h"
-#include "lib/sql_util.h"
#include "lib/string_util.h"
using std::vector;
using std::string;
using hawq::test::SQLUtility;
using hawq::test::Command;
+TestHawqRanger::TestHawqRanger()
+{
+ initfile = hawq::test::stringFormat("Ranger/sql/init_file");
+ rangerHost = getRangerHost();
+}
+
+std::string& TestHawqRanger::getRangerHost()
--- End diff --
Better to get guc value by connecting to db and using sql from pg_settings,
not hawq config. Using sql could avoid string find and hardcoded number length.
And hawq config also connect to db and use sql to get the value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
