Github user linwen commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1171#discussion_r106084037
  
    --- Diff: src/test/feature/Ranger/test_ranger.cpp ---
    @@ -24,19 +24,34 @@
     
     #include "lib/command.h"
     #include "lib/gpfdist.h"
    -#include "lib/sql_util.h"
     #include "lib/string_util.h"
     
     using std::vector;
     using std::string;
     using hawq::test::SQLUtility;
     using hawq::test::Command;
     
    +TestHawqRanger::TestHawqRanger()
    +{
    +   initfile = hawq::test::stringFormat("Ranger/sql/init_file");
    +   rangerHost = getRangerHost();
    +}
    +
    +std::string& TestHawqRanger::getRangerHost()
    --- End diff --
    
    The RPS and HAWQ master are required to installed on a same node. This test 
case is to add/remove policy from Ranger Admin, but HAWQ only knows and 
interacts with RPS, it need not configure Ranger Admin address/hostname. 
    
    I am considering still use a environment value to control it.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to