Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1228#discussion_r114693412
--- Diff: tools/bin/hawq_ctl ---
@@ -737,25 +739,28 @@ class HawqStart:
logger.info("Segments started successfully")
return node_init.return_flag
- def _start_rps(self):
- logger.info("Start ranger plugin service")
+ def _start_rps(self, master_or_standby):
--- End diff --
It's better not identify parameter as "master_or_standby", since this looks
like a boolean value, and is not valid for internal implementation of start_rps
function. I'd recommend to rename it to "hostname" or other similar name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
