Github user ictmalili commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1228#discussion_r114693454
  
    --- Diff: tools/bin/hawq_ctl ---
    @@ -737,25 +739,28 @@ class HawqStart:
                 logger.info("Segments started successfully")
             return node_init.return_flag
     
    -    def _start_rps(self):
    -        logger.info("Start ranger plugin service")
    +    def _start_rps(self, master_or_standby):
    +        logger.info("Start ranger plugin service on %s" % 
master_or_standby)
             cmd_str = "%s/ranger/bin/rps.sh start" % (self.GPHOME)
    -        result = remote_ssh(cmd_str, self.master_host_name, self.user)
    +        result = remote_ssh(cmd_str, master_or_standby, self.user)
             return result
     
    -    def start_rps(self):
    -        check_return_code(self._start_rps(), logger, \
    -                          "Ranger plugin service start failed, exit", 
"Ranger plugin service started successfully")
    +    def start_rps(self, master_or_standby):
    --- End diff --
    
    The same comment for "master_or_standby" parameter name in start_rps


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to