Github user interma commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1274#discussion_r131583088
  
    --- Diff: depends/libhdfs3/src/client/CryptoCodec.cpp ---
    @@ -119,33 +119,38 @@ namespace Hdfs {
                        return -1;
                }
     
    -           //calculate new IV when appending a existed file
    +           // Calculate iv and counter in order to init cipher context 
with cipher method. Default value is 0.
    +           resetStreamOffset(crypto_method, stream_offset);
    --- End diff --
    
    check return value: if `resetStreamOffset()` failed, return -1 here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to